Additional SyliusTwigHook parameter (type)#314
Open
tomkalon wants to merge 3 commits intoSylius:mainfrom
Open
Conversation
tomkalon
force-pushed
the
feature/twig-hook-type-parameter
branch
from
d25e71e to
3b320d2
Compare
Rafikooo
reviewed
Nov 28, 2025
|
|
||
| final class Configuration implements ConfigurationInterface | ||
| { | ||
| public function getConfigTreeBuilder(): TreeBuilder |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * @return TreeBuilder<'array'> | |
| */ | |
| public function getConfigTreeBuilder(): TreeBuilder |
Here you have more inspiration: https://github.com/Sylius/SyliusGridBundle/blob/1.15/src/Bundle/DependencyInjection/Configuration.php#L25
tomkalon
force-pushed
the
feature/twig-hook-type-parameter
branch
3 times, most recently
from
9079935 to
6148f7f
Compare
tomkalon
force-pushed
the
feature/twig-hook-type-parameter
branch
from
6148f7f to
f870fa2
Compare
…logic and tests."
tomkalon
force-pushed
the
feature/twig-hook-type-parameter
branch
5 times, most recently
from
eb793a2 to
4bbdf3b
Compare
…lify ignore rules for NodeBuilder-related false positives."
tomkalon
force-pushed
the
feature/twig-hook-type-parameter
branch
from
4bbdf3b to
f08fd6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to add the type parameter to TwigHook:
Can be overwritten by: